Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unmaintained appdirs with platformdirs #33

Merged
merged 1 commit into from
Nov 17, 2021
Merged

Replace unmaintained appdirs with platformdirs #33

merged 1 commit into from
Nov 17, 2021

Conversation

jugmac00
Copy link
Member

@jugmac00 jugmac00 commented Nov 10, 2021 •
edited
Loading

See ActiveState/appdirs#79

  • Have you signed the CLA?

I will clarify whether I need to sign the CLA as an employee of Canonical.

Update:
I spoke with HR - CLA is not necessary as I created the PR during work time.

facundobatista
facundobatista approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@facundobatista facundobatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@facundobatista facundobatista merged commit cbe7033 into canonical:main Nov 17, 2021
tigarmo pushed a commit that referenced this pull request Jun 6, 2023
@mr-cal
lint(shellcheck): replace find with git ls-files (#33)
a0e2622 
Signed-off-by: Callahan Kovacs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundobatista facundobatista facundobatista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jugmac00 @facundobatista